src/typing.cc - Issue 307453005: Fix check for empty type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 307453005: Fix check for empty type (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index f32f0eb393d7c6943146371aee5e2f5eca35391e..6a3c94c0f85e240609b28a8a989eab8a2c7832bb 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -675,7 +675,7 @@ void AstTyper::VisitBinaryOperation(BinaryOperation* expr) {

Bounds l = expr->left()->bounds();

Bounds r = expr->right()->bounds();

Type* lower =

- l.lower->Is(Type::None()) || r.lower->Is(Type::None()) ?

+ !l.lower->IsInhabited() || !r.lower->IsInhabited() ?

Type::None(zone()) :

l.lower->Is(Type::String()) || r.lower->Is(Type::String()) ?

Type::String(zone()) :

« no previous file with comments | « no previous file | no next file » | no next file with comments »