Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 307443003: Revert of Reparent SWProcessManager onto SWContextWrapper. (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org, kinuko
Visibility:
Public.

Description

Revert of Reparent SWProcessManager onto SWContextWrapper. (https://codereview.chromium.org/292973003/) Reason for revert: I suspect this broke ServiceWorkerDispatcherHostTest.EarlyContextDeletion on linux Original issue's description: > Reparent SWProcessManager onto SWContextWrapper. > > This will allow Wrapper::Shutdown to drop all process references synchronously > in a future change, which will make it possible to shutdown Chrome with service > workers running and without hitting the DCHECK in > ProfileDestroyer::DestroyProfileWhenAppropriate(). > > BUG=368570 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272839 TBR=falken@chromium.org,kinuko@chromium.org,jyasskin@chromium.org NOTREECHECKS=true NOTRY=true BUG=368570 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272858

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Reparent SWProcessManager onto SWContextWrapper.
6 years, 7 months ago (2014-05-26 18:29:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/307443003/1
6 years, 7 months ago (2014-05-26 18:30:32 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 18:31:55 UTC) #3
Message was sent while issue was closed.
Change committed as 272858

Powered by Google App Engine
This is Rietveld 408576698