Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 307433004: X87: Skip write barriers in the fast case when setting up local context. (Closed)

Created:
6 years, 7 months ago by Weiliang
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

X87: Skip write barriers in the fast case when setting up local context. Port r21481 (5973b48) Original commit message: The FastNewContextStub always allocates in new space, so we don't need to update the write barrier when copying the parameters to the newly allocated context. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M src/x87/full-codegen-x87.cc View 3 chunks +14 lines, -4 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Weiliang
6 years, 7 months ago (2014-05-27 08:18:01 UTC) #1
danno
LGTM, you should be able to land this yourself.
6 years, 7 months ago (2014-05-27 08:59:08 UTC) #2
Weiliang
6 years, 7 months ago (2014-05-28 04:56:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21541.

Powered by Google App Engine
This is Rietveld 408576698