Oilpan: Allocate all EventTarget derived types on the manged heap.

Source/core/xml/XMLHttpRequestUpload.h

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 25 matching lines @@
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 #include "wtf/Vector.h"
 #include "wtf/text/AtomicStringHash.h"
 
 namespace WebCore {
 
 class ExecutionContext;
 class XMLHttpRequest;
 
-class XMLHttpRequestUpload FINAL : public ScriptWrappable, public XMLHttpRequestEventTarget {
+class XMLHttpRequestUpload FINAL : public NoBaseWillBeRefCountedGarbageCollected<XMLHttpRequestUpload>, public ScriptWrappable, public XMLHttpRequestEventTarget {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(XMLHttpRequestUpload);
 public:
-    static PassOwnPtr<XMLHttpRequestUpload> create(XMLHttpRequest* xmlHttpRequest)
+    static PassOwnPtrWillBeRawPtr<XMLHttpRequestUpload> create(XMLHttpRequest* xmlHttpRequest)
     {
-        return adoptPtr(new XMLHttpRequestUpload(xmlHttpRequest));
+        return adoptPtrWillBeRefCountedGarbageCollected(new XMLHttpRequestUpload(xmlHttpRequest));
     }
 
+#if ENABLE(OILPAN)
+    using RefCountedGarbageCollected::ref;
+    using RefCountedGarbageCollected::deref;
+#else
     void ref() { m_xmlHttpRequest->ref(); }
     void deref() { m_xmlHttpRequest->deref(); }
+#endif

[haraken, 2014/05/27 01:39:19]

Can we avoid writing this by using DEFINE_EVENT_TARGET(XMLHttpRequestUpload) ?

[zerny-chromium, 2014/05/27 07:34:33]

Ditto here.

+
     XMLHttpRequest* xmlHttpRequest() const { return m_xmlHttpRequest; }
 
     virtual const AtomicString& interfaceName() const OVERRIDE;
     virtual ExecutionContext* executionContext() const OVERRIDE;
 
     void dispatchEventAndLoadEnd(const AtomicString&, bool, unsigned long long, unsigned long long);
     void dispatchProgressEvent(unsigned long long, unsigned long long);
 
     void handleRequestError(const AtomicString&);
 
+    virtual void trace(Visitor*) OVERRIDE;
+
 private:
     explicit XMLHttpRequestUpload(XMLHttpRequest*);
 
     virtual void refEventTarget() OVERRIDE { ref(); }
     virtual void derefEventTarget() OVERRIDE { deref(); }
 
-    XMLHttpRequest* m_xmlHttpRequest;
+    RawPtrWillBeMember<XMLHttpRequest> m_xmlHttpRequest;
     EventTargetData m_eventTargetData;
 
     // Last progress event values; used when issuing the
     // required 'progress' event on a request error or abort.
     unsigned long long m_lastBytesSent;
     unsigned long long m_lastTotalBytesToBeSent;
 };
 
 } // namespace WebCore
 
 #endif // XMLHttpRequestUpload_h