Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 307433002: Remove ProtocolFactory use from file_writer_delegate_unittest (Closed)

Created:
6 years, 7 months ago by cbentzel
Modified:
6 years, 6 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam, nhiroki, tzik
Visibility:
Public.

Description

Remove ProtocolFactory use from file_writer_delegate_unittest This is being done to removeuse of a deprecated API in net/ BUG=81979 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M content/browser/fileapi/file_writer_delegate_unittest.cc View 6 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
cbentzel
6 years, 7 months ago (2014-05-26 14:51:28 UTC) #1
michaeln
lgtm
6 years, 7 months ago (2014-05-27 19:37:52 UTC) #2
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-05-28 10:44:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/307433002/1
6 years, 6 months ago (2014-05-28 10:45:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 13:23:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 13:33:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/8039)
6 years, 6 months ago (2014-05-28 13:33:11 UTC) #7
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-05-28 13:44:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/307433002/1
6 years, 6 months ago (2014-05-28 13:45:35 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 13:59:09 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 14:08:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/8054)
6 years, 6 months ago (2014-05-28 14:08:53 UTC) #12
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-05-29 00:29:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/307433002/1
6 years, 6 months ago (2014-05-29 00:30:19 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 00:40:32 UTC) #15
Message was sent while issue was closed. 
Change committed as 273422

Powered by Google App Engine
This is Rietveld 408576698