Temporarily re-enabling SizeAfterPrefChange test with traces

chrome/browser/extensions/extension_toolbar_model_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_toolbar_model.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/test/base/in_process_browser_test.h"
 
 namespace extensions {
 
 // An InProcessBrowserTest for testing the ExtensionToolbarModel.
 // TODO(erikkay) It's unfortunate that this needs to be an in-proc browser test.
 // It would be nice to refactor things so that ExtensionService could run
 // without so much of the browser in place.
 class ExtensionToolbarModelTest : public ExtensionBrowserTest,
                                   public ExtensionToolbarModel::Observer {
  public:
   virtual void SetUp() {
     inserted_count_ = 0;
     removed_count_ = 0;
     moved_count_ = 0;
     highlight_mode_count_ = 0;
 
     ExtensionBrowserTest::SetUp();
   }
 
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+    ExtensionBrowserTest::SetUpCommandLine(command_line);
+#if defined(OS_LINUX) || defined(OS_CHROMEOS)
+    command_line->AppendSwitchNative(
+        "vmodule", "*extension_toolbar_model*=4,*browser_actions_container*=4");
+#endif  // defined(OS_LINUX) || defined(OS_CHROMEOS)
+  }
+
   virtual void SetUpOnMainThread() OVERRIDE {
     model_ = ExtensionToolbarModel::Get(browser()->profile());
     model_->AddObserver(this);
   }
 
   virtual void CleanUpOnMainThread() OVERRIDE {
     model_->RemoveObserver(this);
   }
 
   virtual void BrowserActionAdded(const Extension* extension,
@@ skipping 537 matching lines @@
 
   // When we stop highlighting, we should see the new extension show up.
   model_->StopHighlighting();
   EXPECT_FALSE(model_->is_highlighting());
   EXPECT_EQ(3u, model_->toolbar_items().size());
   EXPECT_EQ(id_a, ExtensionAt(0)->id());
   EXPECT_EQ(id_b, ExtensionAt(1)->id());
   EXPECT_EQ(id_c, ExtensionAt(2)->id());
 }
 
-// Test is flaky on Linus and ChromeOS, see crbug.com/379170.
-#if defined(OS_LINUX) || defined(OS_CHROMEOS)
-#define MAYBE_SizeAfterPrefChange DISABLED_SizeAfterPrefChange
-#else
-#define MAYBE_SizeAfterPrefChange SizeAfterPrefChange
-#endif
-IN_PROC_BROWSER_TEST_F(ExtensionToolbarModelTest, MAYBE_SizeAfterPrefChange) {
+// Test is flaky (see crbug.com/379170), but currently enabled to gather traces.
+// If it fails, ping Finnur.
+IN_PROC_BROWSER_TEST_F(ExtensionToolbarModelTest, SizeAfterPrefChange) {
   // Load two extensions with browser action.
   base::FilePath extension_a_path(test_data_dir_.AppendASCII("api_test")
                                                 .AppendASCII("browser_action")
                                                 .AppendASCII("basics"));
-  LOG(ERROR) << "Loading [basics]";
+  VLOG(4) << "Loading [basics]";
   ASSERT_TRUE(LoadExtension(extension_a_path));
   base::FilePath extension_b_path(test_data_dir_.AppendASCII("api_test")
                                                 .AppendASCII("browser_action")
                                                 .AppendASCII("popup"));
-  LOG(ERROR) << "Loading [popup]";
+  VLOG(4) << "Loading [popup]";
   ASSERT_TRUE(LoadExtension(extension_b_path));
   std::string id_a = ExtensionAt(0)->id();
   std::string id_b = ExtensionAt(1)->id();
 
-  LOG(ERROR) << "GetVisibleIconCount";
+  VLOG(4) << "GetVisibleIconCount";
 
   // Should be at max size (-1).
   EXPECT_EQ(-1, model_->GetVisibleIconCount());
 
-  LOG(ERROR) << "OnExtensionToolbarPrefChange";
+  VLOG(4) << "OnExtensionToolbarPrefChange";
   model_->OnExtensionToolbarPrefChange();
 
-  LOG(ERROR) << "GetVisibleIconCount";
+  VLOG(4) << "GetVisibleIconCount";
 
   // Should still be at max size.
   EXPECT_EQ(-1, model_->GetVisibleIconCount());
 }
 
 }  // namespace extensions