Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 307413002: Move ExtensionUninstallDialog into extensions namespace (Closed)

Created:
6 years, 6 months ago by limasdf
Modified:
6 years, 6 months ago
Reviewers:
Devlin, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, tfarina, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionUninstallDialog into extensions namespace and remove unwanted extensions:: prefix in extension_uninstall_dialog.*. BUG=380149 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274743

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -79 lines) Patch
M chrome/browser/extensions/extension_context_menu_model.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.h View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 4 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/ui/app_list/extension_uninstaller.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/extension_uninstaller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
limasdf
PTAL and Could you run mac_rel try bot? Unfortunately I don't have Mac machine.
6 years, 6 months ago (2014-06-03 16:53:17 UTC) #1
Devlin
c/b/e lgtm, but you might want to update the description to be "Move ExtensionUninstallDialog into ...
6 years, 6 months ago (2014-06-03 17:09:24 UTC) #2
Devlin
On 2014/06/03 17:09:24, Devlin wrote: > c/b/e lgtm, but you might want to update the ...
6 years, 6 months ago (2014-06-03 17:10:50 UTC) #3
limasdf
added @sky for c/b/ui @sky This change is a mecanical change in ui. please take ...
6 years, 6 months ago (2014-06-03 17:18:38 UTC) #4
sky
LGTM
6 years, 6 months ago (2014-06-03 20:04:06 UTC) #5
limasdf
thanks for the reviews @devlin, @sky
6 years, 6 months ago (2014-06-03 20:04:59 UTC) #6
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 6 months ago (2014-06-03 20:20:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/307413002/30001
6 years, 6 months ago (2014-06-03 20:20:49 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-04 00:12:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 00:14:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/13602)
6 years, 6 months ago (2014-06-04 00:14:58 UTC) #11
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 6 months ago (2014-06-04 04:42:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/307413002/30001
6 years, 6 months ago (2014-06-04 04:44:48 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:18:49 UTC) #14
Message was sent while issue was closed.
Change committed as 274743

Powered by Google App Engine
This is Rietveld 408576698