Issue 307393002: Misc cleanup (split from the "delay string / value internalization" CL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307393002: Misc cleanup (split from the "delay string / value internalization" CL). (Closed)

Created:
6 years, 6 months ago by marja

Modified:
6 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Misc cleanup (split from the "delay string / value internalization" CL). - Missing includes / forward declaration - Parser: Simplifying calling error reporting funcs. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21652

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
M	src/list.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/preparser.h	View	1 2	5 chunks	+7 lines, -11 lines	0 comments	Download
M	src/utils.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

marja

6 years, 6 months ago (2014-06-03 16:12:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r21652 (presubmit successful).