Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 307373003: Remove brackets from gm names. (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
Reviewers:
epoger, borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove more brackets... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M gm/blurroundrect.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scroggo
6 years, 6 months ago (2014-06-03 13:15:41 UTC) #1
borenet
LGTM but wishing we had an easy pre-flight to make sure we don't accidentally add ...
6 years, 6 months ago (2014-06-03 13:17:26 UTC) #2
scroggo
On 2014/06/03 13:17:26, borenet wrote: > LGTM but wishing we had an easy pre-flight to ...
6 years, 6 months ago (2014-06-03 13:41:03 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-03 13:41:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/307373003/20001
6 years, 6 months ago (2014-06-03 13:41:22 UTC) #5
commit-bot: I haz the power
Change committed as ef470f185f0dcd94943d0c470ddf8cc109f30325
6 years, 6 months ago (2014-06-03 13:50:30 UTC) #6
epoger
6 years, 6 months ago (2014-06-03 13:52:47 UTC) #7
Message was sent while issue was closed.
On 2014/06/03 13:17:26, borenet wrote:
> LGTM but wishing we had an easy pre-flight to make sure we don't accidentally
> add more.

At least for GMs, when a new GM test is added it won't have any expectations. 
So it will upload its results on first run for sure, triggering this error.

I think a new test like you describe in
https://code.google.com/p/skia/issues/detail?id=2634#c15 ("running each of the
binaries which produce files, forcing them to always write everything to files,
and then asserting that all of the produced files had valid names") is a good
idea, but I don't know where it fits in the global priority scheme.  Filed
http://skbug.com/2636 ('add unittest for all our tools to confirm that filenames
written out are legal') for that idea.

Powered by Google App Engine
This is Rietveld 408576698