mojo/public/cpp/bindings/lib/array_internal.cc - Issue 307353009: Mojo cpp bindings: report the reason of validation failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/array_internal.cc

Issue 307353009: Mojo cpp bindings: report the reason of validation failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/array_internal.cc

diff --git a/mojo/public/cpp/bindings/lib/array_internal.cc b/mojo/public/cpp/bindings/lib/array_internal.cc

index 18443edcb960c79b7f61a6d440e0189f77b5c3ce..3f7f1ce0b16bb14da7d5779ac9e6f33f64509371 100644

--- a/mojo/public/cpp/bindings/lib/array_internal.cc

+++ b/mojo/public/cpp/bindings/lib/array_internal.cc

@@ -58,8 +58,10 @@ bool ArraySerializationHelper<Handle, true>::ValidateElements(

const ElementType* elements,

BoundsChecker* bounds_checker) {

for (uint32_t i = 0; i < header->num_elements; ++i) {

- if (!bounds_checker->ClaimHandle(elements[i]))

+ if (!bounds_checker->ClaimHandle(elements[i])) {

+ ReportValidationError(VALIDATION_ERROR_ILLEGAL_HANDLE);

return false;

+ }

}

return true;

}