GCD registration ticket creation flow

GCD registration ticket creation flow

GCD API flow for registration ticket creation

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274759

[Vitaly Buka (NO REVIEWS), 2014-06-03 21:30:48]

lgtm

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/gcd_registration_ticket_creator.cc (right):

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/gcd_registration_ticket_creator.cc:14: 
empty lines inconsistent

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/gcd_registration_ticket_creator.h (right):

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/gcd_registration_ticket_creator.h:16: class
GCDRegistrationTicketCreator : public GCDApiFlowRequest {
maybe GCDRegistrationTicketCreator -> GCDRegistrationTicket

[Noam Samuel, 2014-06-03 21:48:13]

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/gcd_registration_ticket_creator.cc (right):

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/gcd_registration_ticket_creator.cc:14: 
On 2014/06/03 21:30:49, Vitaly Buka wrote:
> empty lines inconsistent

Done.

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/gcd_registration_ticket_creator.h (right):

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/gcd_registration_ticket_creator.h:16: class
GCDRegistrationTicketCreator : public GCDApiFlowRequest {
On 2014/06/03 21:30:49, Vitaly Buka wrote:
> maybe GCDRegistrationTicketCreator -> GCDRegistrationTicket

Worried people will think this is an object representing the ticket data rather
than a creation flow.

[Vitaly Buka (NO REVIEWS), 2014-06-03 22:02:47]

On 2014/06/03 21:48:13, Noam Samuel wrote:
>
https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
> File chrome/browser/local_discovery/gcd_registration_ticket_creator.cc
(right):
> 
>
https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
> chrome/browser/local_discovery/gcd_registration_ticket_creator.cc:14: 
> On 2014/06/03 21:30:49, Vitaly Buka wrote:
> > empty lines inconsistent
> 
> Done.
> 
>
https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
> File chrome/browser/local_discovery/gcd_registration_ticket_creator.h (right):
> 
>
https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
> chrome/browser/local_discovery/gcd_registration_ticket_creator.h:16: class
> GCDRegistrationTicketCreator : public GCDApiFlowRequest {
> On 2014/06/03 21:30:49, Vitaly Buka wrote:
> > maybe GCDRegistrationTicketCreator -> GCDRegistrationTicket
> 
> Worried people will think this is an object representing the ticket data
rather
> than a creation flow.

Not it sound like design patter.

[Noam Samuel, 2014-06-03 22:28:39]

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
File chrome/browser/local_discovery/gcd_registration_ticket_creator.h (right):

https://codereview.chromium.org/307353008/diff/1/chrome/browser/local_discove...
chrome/browser/local_discovery/gcd_registration_ticket_creator.h:16: class
GCDRegistrationTicketCreator : public GCDApiFlowRequest {
On 2014/06/03 21:48:13, Noam Samuel wrote:
> On 2014/06/03 21:30:49, Vitaly Buka wrote:
> > maybe GCDRegistrationTicketCreator -> GCDRegistrationTicket
> 
> Worried people will think this is an object representing the ticket data
rather
> than a creation flow.

Renamed to GCDRegistrationTicketRequest

[Noam Samuel, 2014-06-03 22:28:42]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-06-03 22:31:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/307353008/40001

[commit-bot: I haz the power, 2014-06-04 10:55:12]

Change committed as 274759