Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 307353004: Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 307353004: Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js

index d11ed4fce32bc8a2f4a956eabc137ff81fb3a65b..e906730e55dd165fdc3a40b80fa0615203463bff 100644

--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -504,7 +504,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {

if (event) {

var name = WebInspector.TimelineUIUtils.styleForTimelineEvent(event.name).title;

// TODO(yurys): support event dividers

- var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier, false, this._traceEventBindings, this._target);

+ var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier, false, this._traceEventBindings, this._target);

return details ? WebInspector.UIString("%s (%s)", name, details.textContent) : name;

}

var title = this._entryIndexToTitle[entryIndex];