Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 307353004: Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased, addressed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 /** 495 /**
496 * @param {number} entryIndex 496 * @param {number} entryIndex
497 * @return {?string} 497 * @return {?string}
498 */ 498 */
499 entryTitle: function(entryIndex) 499 entryTitle: function(entryIndex)
500 { 500 {
501 var event = this._entryEvents[entryIndex]; 501 var event = this._entryEvents[entryIndex];
502 if (event) { 502 if (event) {
503 var name = WebInspector.TimelineUIUtils.styleForTimelineEvent(event. name).title; 503 var name = WebInspector.TimelineUIUtils.styleForTimelineEvent(event. name).title;
504 // TODO(yurys): support event dividers 504 // TODO(yurys): support event dividers
505 var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceE vent(event, this._linkifier, false, this._target); 505 var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeFo rTraceEvent(event, this._linkifier, false, this._target);
506 return details ? WebInspector.UIString("%s (%s)", name, details.text Content) : name; 506 return details ? WebInspector.UIString("%s (%s)", name, details.text Content) : name;
507 } 507 }
508 var title = this._entryIndexToTitle[entryIndex]; 508 var title = this._entryIndexToTitle[entryIndex];
509 if (!title) { 509 if (!title) {
510 title = WebInspector.UIString("Unexpected entryIndex %d", entryIndex ); 510 title = WebInspector.UIString("Unexpected entryIndex %d", entryIndex );
511 console.error(title); 511 console.error(title);
512 } 512 }
513 return title; 513 return title;
514 }, 514 },
515 515
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
980 * @param {number} entryIndex 980 * @param {number} entryIndex
981 * @return {?WebInspector.TimelineSelection} 981 * @return {?WebInspector.TimelineSelection}
982 */ 982 */
983 createSelection: function(entryIndex) { }, 983 createSelection: function(entryIndex) { },
984 /** 984 /**
985 * @param {?WebInspector.TimelineSelection} selection 985 * @param {?WebInspector.TimelineSelection} selection
986 * @return {number} 986 * @return {number}
987 */ 987 */
988 entryIndexForSelection: function(selection) { } 988 entryIndexForSelection: function(selection) { }
989 } 989 }
OLDNEW
« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698