Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 307353004: Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 /** 497 /**
498 * @param {number} entryIndex 498 * @param {number} entryIndex
499 * @return {?string} 499 * @return {?string}
500 */ 500 */
501 entryTitle: function(entryIndex) 501 entryTitle: function(entryIndex)
502 { 502 {
503 var event = this._entryEvents[entryIndex]; 503 var event = this._entryEvents[entryIndex];
504 if (event) { 504 if (event) {
505 var name = WebInspector.TimelineUIUtils.styleForTimelineEvent(event. name).title; 505 var name = WebInspector.TimelineUIUtils.styleForTimelineEvent(event. name).title;
506 // TODO(yurys): support event dividers 506 // TODO(yurys): support event dividers
507 var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceE vent(event, this._linkifier, false, this._traceEventBindings, this._target); 507 var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeFo rTraceEvent(event, this._linkifier, false, this._traceEventBindings, this._targe t);
508 return details ? WebInspector.UIString("%s (%s)", name, details.text Content) : name; 508 return details ? WebInspector.UIString("%s (%s)", name, details.text Content) : name;
509 } 509 }
510 var title = this._entryIndexToTitle[entryIndex]; 510 var title = this._entryIndexToTitle[entryIndex];
511 if (!title) { 511 if (!title) {
512 title = WebInspector.UIString("Unexpected entryIndex %d", entryIndex ); 512 title = WebInspector.UIString("Unexpected entryIndex %d", entryIndex );
513 console.error(title); 513 console.error(title);
514 } 514 }
515 return title; 515 return title;
516 }, 516 },
517 517
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 * @param {number} entryIndex 983 * @param {number} entryIndex
984 * @return {?WebInspector.TimelineSelection} 984 * @return {?WebInspector.TimelineSelection}
985 */ 985 */
986 createSelection: function(entryIndex) { }, 986 createSelection: function(entryIndex) { },
987 /** 987 /**
988 * @param {?WebInspector.TimelineSelection} selection 988 * @param {?WebInspector.TimelineSelection} selection
989 * @return {number} 989 * @return {number}
990 */ 990 */
991 entryIndexForSelection: function(selection) { } 991 entryIndexForSelection: function(selection) { }
992 } 992 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698