Issue 307353004: Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js

Issue 307353004: Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js (Closed)

Created:
6 years, 6 months ago by caseq

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: extract tracing-specific UI helpers into TracingTimelineUIUtils.js BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175468

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased, addressed comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+409 lines, -397 lines)			Patch
M	Source/devtools/devtools.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	1	2 chunks	+0 lines, -395 lines	0 comments	Download
A	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View	1	1 chunk	+404 lines, -0 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/307353004/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js File Source/devtools/front_end/timeline/TracingTimelineUIUtils.js (right): https://codereview.chromium.org/307353004/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js#newcode1 Source/devtools/front_end/timeline/TracingTimelineUIUtils.js:1: // Pleas remove empty // lines around the ...

6 years, 6 months ago (2014-06-04 06:47:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/307353004/20001

6 years, 6 months ago (2014-06-04 07:40:48 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-04 08:58:39 UTC) #5

Message was sent while issue was closed.

Change committed as 175468

Expand Messages | Collapse Messages