Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 307353002: Use Position instead of VisiblePosition for SurroundingText. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix crash Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 83d287b7ae5a15d71b25d9c1600ab7897aff0075..83d7015a285ebbd0e64c51ceb55abd5df51d905c 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -725,12 +725,7 @@ PassRefPtrWillBeRawPtr<Range> makeRange(const VisiblePosition &start, const Visi
if (start.isNull() || end.isNull())
return nullptr;
- Position s = start.deepEquivalent().parentAnchoredEquivalent();
- Position e = end.deepEquivalent().parentAnchoredEquivalent();
- if (s.isNull() || e.isNull())
- return nullptr;
-
- return Range::create(s.containerNode()->document(), s.containerNode(), s.offsetInContainerNode(), e.containerNode(), e.offsetInContainerNode());
+ return makeRange(start.deepEquivalent(), end.deepEquivalent());
}
VisiblePosition startVisiblePosition(const Range *r, EAffinity affinity)

Powered by Google App Engine
This is Rietveld 408576698