Source/web/WebSurroundingText.cpp - Issue 307353002: Use Position instead of VisiblePosition for SurroundingText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSurroundingText.cpp

Issue 307353002: Use Position instead of VisiblePosition for SurroundingText. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: convert layouttests to unit tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSurroundingText.cpp

diff --git a/Source/web/WebSurroundingText.cpp b/Source/web/WebSurroundingText.cpp

index 54a2f7a1030fdff446f1a346d967e88d73cd4273..6121370cc386030381994c06acdbcd253d77e901 100644

--- a/Source/web/WebSurroundingText.cpp

+++ b/Source/web/WebSurroundingText.cpp

@@ -45,7 +45,7 @@ void WebSurroundingText::initialize(const WebNode& webNode, const WebPoint& node

if (!node || !node->renderer())

return;

- m_private.reset(new SurroundingText(VisiblePosition(node->renderer()->positionForPoint(static_cast<IntPoint>(nodePoint))), maxLength));

+ m_private.reset(new SurroundingText(node->renderer()->positionForPoint(static_cast<IntPoint>(nodePoint)).position(), maxLength));

mlamouri (slow - plz ping) 2014/06/04 14:56:39 If I manually test this on Android, it is crashing

}

WebString WebSurroundingText::textContent() const

« no previous file with comments | « Source/core/testing/Internals.idl ('k') | no next file » | no next file with comments »