Use Position instead of VisiblePosition for SurroundingText.

Source/core/dom/Position.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1268 matching lines @@
     for (const RenderObject* r = m_anchorNode->renderer(); r; r = r->parent()) {
         if (r->isRenderBlockFlow()) {
             primaryDirection = r->style()->direction();
             break;
         }
     }
 
     return primaryDirection;
 }
 
+PassRefPtrWillBeRawPtr<Range> makeRange(const Position& start, const Position& end)
+{
+    if (start.isNull() || end.isNull())
+        return nullptr;
+
+    Position s = start.parentAnchoredEquivalent();
+    Position e = end.parentAnchoredEquivalent();

[Yuta Kitamura, 2014/06/06 08:57:30]

What's the point of getting parent-anchored version of
|start| and |end|?

[mlamouri (slow - plz ping), 2014/06/06 09:23:15]

Removed. I'm calling directly Range::create() instead.

+    if (s.isNull() || e.isNull())
+        return nullptr;
+
+    return Range::create(s.containerNode()->document(), s.containerNode(), s.offsetInContainerNode(), e.containerNode(), e.offsetInContainerNode());
+}
+
 void Position::trace(Visitor* visitor)
 {
     visitor->trace(m_anchorNode);
 }
 
 void Position::debugPosition(const char* msg) const
 {
     if (isNull())
         fprintf(stderr, "Position [%s]: null\n", msg);
     else
@@ skipping 65 matching lines @@
     pos.showTreeForThis();
 }
 
 void showTree(const WebCore::Position* pos)
 {
     if (pos)
         pos->showTreeForThis();
 }
 
 #endif