Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 307323002: asan: Fix asan leak from r274404. (Closed)

Created:
6 years, 6 months ago by sadrul
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

asan: Fix asan leak from r274404. Make sure the initiated animations are terminated correctly before teardown. BUG=none TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274409

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 2 chunks +10 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
6 years, 6 months ago (2014-06-03 02:30:53 UTC) #1
sadrul
Committed patchset #1 manually as r274409 (tree was closed).
6 years, 6 months ago (2014-06-03 02:37:45 UTC) #2
sky
https://codereview.chromium.org/307323002/diff/1/content/browser/web_contents/web_contents_view_aura_browsertest.cc File content/browser/web_contents/web_contents_view_aura_browsertest.cc (right): https://codereview.chromium.org/307323002/diff/1/content/browser/web_contents/web_contents_view_aura_browsertest.cc#newcode271 content/browser/web_contents/web_contents_view_aura_browsertest.cc:271: ui::DrawWaiterForTest::Wait(compositor); This seems easy to miss. Who owns these ...
6 years, 6 months ago (2014-06-03 13:19:15 UTC) #3
sadrul
6 years, 6 months ago (2014-06-03 18:35:04 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/307323002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_view_aura_browsertest.cc (right):

https://codereview.chromium.org/307323002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_view_aura_browsertest.cc:271:
ui::DrawWaiterForTest::Wait(compositor);
On 2014/06/03 13:19:15, sky wrote:
> This seems easy to miss. Who owns these animations and how come they aren't
> normally destroyed when the owner is destroyed?

This CL was reverted (along with the original CL). I am going to look for a
better fix than this. I will ping for a review when I find one.

Powered by Google App Engine
This is Rietveld 408576698