chrome/app/PRESUBMIT.py - Issue 3073020: Remove warning about GRD changes which is no longer required.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/PRESUBMIT.py

Issue 3073020: Remove warning about GRD changes which is no longer required. (Closed)

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5 """Notify people of GRD changes."""

6

7 GRD_FILE_ENDING = 'resources.grd'

8

9 def CheckChangeOnCommit(input_api, output_api):

10 results = []

11 for f in input_api.AffectedFiles():

12 if f.LocalPath().endswith(GRD_FILE_ENDING):

13 results = [ output_api.PresubmitPromptWarning('Your CL includes a GRD '

14 'change. Please notify the sheriff BEFORE landing.\nSee this page '

15 'for more information:\n '

16 'http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-'

17 'chromium') ]

18 break

19 return results

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »