Issue 3073008: BrowserMain() refactoring, part 2.1.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3073008: BrowserMain() refactoring, part 2.1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by viettrungluu

Modified:
3 years, 11 months ago

Reviewers:
cpu, rohitrao (OOO until 6-22)

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

BrowserMain() refactoring, part 2.1. 1. Move InitializeSSL() into platform-specific files and eliminate #ifdef. 2. Add some instructions on how to add code to BrowserMain(). BUG=none TEST=everything still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54098

Patch Set 1 #

Patch Set 2 : build fix #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -35 lines)			Patch
M	chrome/browser/browser_main.h	View		2 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/browser_main.cc	View	1	5 chunks	+19 lines, -34 lines	0 comments	Download
M	chrome/browser/browser_main_mac.mm	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_main_posix.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View		3 chunks	+16 lines, -0 lines	0 comments	Download

Trybot results: linux win mac

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu

4 years, 10 months ago (2010-07-29 04:25:45 UTC) #2

lgtm

a mail to chromium-dev would help the cause, I mean awareness of this
refactoring

Expand Messages | Collapse Messages