Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 307293002: Add missing 'break' statements to ppapi::proxy::NaClMessageScanner. (Closed)

Created:
6 years, 6 months ago by bbudge
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing 'break' statements to ppapi::proxy::NaClMessageScanner. Two cases don't have breaks and fall through incorrectly. The first may be responsible for issue http://crbug.com/370919. BUG=370919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ppapi/proxy/nacl_message_scanner.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bbudge
6 years, 6 months ago (2014-06-02 21:41:27 UTC) #1
dmichael (off chromium)
lgtm
6 years, 6 months ago (2014-06-02 21:42:52 UTC) #2
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 6 months ago (2014-06-02 21:46:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/307293002/1
6 years, 6 months ago (2014-06-02 21:47:16 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 02:13:33 UTC) #5
Message was sent while issue was closed.
Change committed as 274408

Powered by Google App Engine
This is Rietveld 408576698