Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 307263003: MSE: Always use new FrameProcessor's coded frame processing (Closed)

Created:
6 years, 6 months ago by wolenetz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

MSE: Always use new FrameProcessor's coded frame processing This change ignores Blink's signalling of whether or not to use LegacyFrameProcessor, and instead always uses the new, compliant, FrameProcessor to handle SourceBuffer coded frame processing. R=acolwell@chromium.org TEST=Linux Debug: no media_unittest or MSE layout test regression; Linux Release with proprietary codecs: no regression of yt-dash-mse-test ToT BUG=249422 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274468

Patch Set 1 #

Patch Set 2 : Keep testing both types of frame processors for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M content/renderer/media/webmediasource_impl.cc View 1 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wolenetz
PTAL @ PS1 Thanks!
6 years, 6 months ago (2014-06-02 22:20:23 UTC) #1
acolwell GONE FROM CHROMIUM
Any reason not to make the change in WebMediaSourceImpl instead? I'm just wondering if there ...
6 years, 6 months ago (2014-06-02 23:14:35 UTC) #2
wolenetz
On 2014/06/02 23:14:35, acolwell wrote: > Any reason not to make the change in WebMediaSourceImpl ...
6 years, 6 months ago (2014-06-02 23:17:41 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm
6 years, 6 months ago (2014-06-02 23:35:03 UTC) #4
wolenetz
Thank you for review.
6 years, 6 months ago (2014-06-02 23:39:40 UTC) #5
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 6 months ago (2014-06-02 23:39:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/307263003/20001
6 years, 6 months ago (2014-06-02 23:43:55 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 11:53:52 UTC) #8
Message was sent while issue was closed.
Change committed as 274468

Powered by Google App Engine
This is Rietveld 408576698