Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 307243004: Avoid calling slower Node::firstChild() / Node::lastChild() when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/NodeTraversal.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1476 case Node::ELEMENT_NODE: 1476 case Node::ELEMENT_NODE:
1477 if (isHTMLBRElement(*node) && convertBRsToNewlines) { 1477 if (isHTMLBRElement(*node) && convertBRsToNewlines) {
1478 isNullString = false; 1478 isNullString = false;
1479 content.append('\n'); 1479 content.append('\n');
1480 break; 1480 break;
1481 } 1481 }
1482 // Fall through. 1482 // Fall through.
1483 case Node::ATTRIBUTE_NODE: 1483 case Node::ATTRIBUTE_NODE:
1484 case Node::DOCUMENT_FRAGMENT_NODE: 1484 case Node::DOCUMENT_FRAGMENT_NODE:
1485 isNullString = false; 1485 isNullString = false;
1486 for (Node* child = node->firstChild(); child; child = child->nextSibling ()) { 1486 for (Node* child = toContainerNode(node)->firstChild(); child; child = c hild->nextSibling()) {
1487 Node::NodeType childNodeType = child->nodeType(); 1487 Node::NodeType childNodeType = child->nodeType();
1488 if (childNodeType == Node::COMMENT_NODE || childNodeType == Node::PR OCESSING_INSTRUCTION_NODE) 1488 if (childNodeType == Node::COMMENT_NODE || childNodeType == Node::PR OCESSING_INSTRUCTION_NODE)
1489 continue; 1489 continue;
1490 appendTextContent(child, convertBRsToNewlines, isNullString, content ); 1490 appendTextContent(child, convertBRsToNewlines, isNullString, content );
1491 } 1491 }
1492 break; 1492 break;
1493 1493
1494 case Node::DOCUMENT_NODE: 1494 case Node::DOCUMENT_NODE:
1495 case Node::DOCUMENT_TYPE_NODE: 1495 case Node::DOCUMENT_TYPE_NODE:
1496 break; 1496 break;
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
2578 node->showTreeForThis(); 2578 node->showTreeForThis();
2579 } 2579 }
2580 2580
2581 void showNodePath(const WebCore::Node* node) 2581 void showNodePath(const WebCore::Node* node)
2582 { 2582 {
2583 if (node) 2583 if (node)
2584 node->showNodePathForThis(); 2584 node->showNodePathForThis();
2585 } 2585 }
2586 2586
2587 #endif 2587 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/NodeTraversal.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698