Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: Source/core/dom/ContainerNode.cpp

Issue 307243004: Avoid calling slower Node::firstChild() / Node::lastChild() when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 willBeDeletedFromDocument(); 101 willBeDeletedFromDocument();
102 removeDetachedChildren(); 102 removeDetachedChildren();
103 #endif 103 #endif
104 } 104 }
105 105
106 bool ContainerNode::isChildTypeAllowed(const Node& child) const 106 bool ContainerNode::isChildTypeAllowed(const Node& child) const
107 { 107 {
108 if (!child.isDocumentFragment()) 108 if (!child.isDocumentFragment())
109 return childTypeAllowed(child.nodeType()); 109 return childTypeAllowed(child.nodeType());
110 110
111 for (Node* node = child.firstChild(); node; node = node->nextSibling()) { 111 for (Node* node = toDocumentFragment(child).firstChild(); node; node = node- >nextSibling()) {
112 if (!childTypeAllowed(node->nodeType())) 112 if (!childTypeAllowed(node->nodeType()))
113 return false; 113 return false;
114 } 114 }
115 return true; 115 return true;
116 } 116 }
117 117
118 bool ContainerNode::containsConsideringHostElements(const Node& newChild) const 118 bool ContainerNode::containsConsideringHostElements(const Node& newChild) const
119 { 119 {
120 if (isInShadowTree() || document().isTemplateDocument()) 120 if (isInShadowTree() || document().isTemplateDocument())
121 return newChild.containsIncludingHostElements(*this); 121 return newChild.containsIncludingHostElements(*this);
(...skipping 1156 matching lines...) Expand 10 before | Expand all | Expand 10 after
1278 return true; 1278 return true;
1279 1279
1280 if (node->isElementNode() && toElement(node)->shadow()) 1280 if (node->isElementNode() && toElement(node)->shadow())
1281 return true; 1281 return true;
1282 1282
1283 return false; 1283 return false;
1284 } 1284 }
1285 #endif 1285 #endif
1286 1286
1287 } // namespace WebCore 1287 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698