Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1984)

Unified Diff: Source/platform/fonts/android/FontCacheAndroid.cpp

Issue 307243002: Fix font family based fallback font selection (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Windows link fix. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/FontFaceCreationParams.h ('k') | Source/platform/fonts/linux/FontCacheLinux.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/android/FontCacheAndroid.cpp
diff --git a/Source/platform/fonts/android/FontCacheAndroid.cpp b/Source/platform/fonts/android/FontCacheAndroid.cpp
index 72c649d07ab4a21287de80e9a6cc1638b6238aa2..d0b6afc080c9761f9ce10d1707b38a586a02a29c 100644
--- a/Source/platform/fonts/android/FontCacheAndroid.cpp
+++ b/Source/platform/fonts/android/FontCacheAndroid.cpp
@@ -34,6 +34,7 @@
#include "platform/fonts/SimpleFontData.h"
#include "platform/fonts/FontDescription.h"
+#include "platform/fonts/FontFaceCreationParams.h"
#include "SkTypeface_android.h"
@@ -74,7 +75,7 @@ PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(const FontDescrip
AtomicString familyName = getFamilyNameForCharacter(c, fontDescription.script());
if (familyName.isEmpty())
return getLastResortFallbackFont(fontDescription, DoNotRetain);
- return fontDataFromFontPlatformData(getFontPlatformData(fontDescription, familyName), DoNotRetain);
+ return fontDataFromFontPlatformData(getFontPlatformData(fontDescription, FontFaceCreationParams(familyName)), DoNotRetain);
}
// static
« no previous file with comments | « Source/platform/fonts/FontFaceCreationParams.h ('k') | Source/platform/fonts/linux/FontCacheLinux.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698