Source/platform/fonts/FontDescription.h - Issue 307243002: Fix font family based fallback font selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/FontDescription.h

Issue 307243002: Fix font family based fallback font selection (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Windows link fix. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/FontDescription.h

diff --git a/Source/platform/fonts/FontDescription.h b/Source/platform/fonts/FontDescription.h

index 9cefae0436a002fe2cde08e1388cad87c6c91946..2b6657a82074671cc54348c1da73b87690004cc1 100644

--- a/Source/platform/fonts/FontDescription.h

+++ b/Source/platform/fonts/FontDescription.h

@@ -127,7 +127,7 @@ public:

FontDescription makeNormalFeatureSettings() const;

float effectiveFontSize() const; // Returns either the computedSize or the computedPixelSize

- FontCacheKey cacheKey(const AtomicString& familyName, FontTraits desiredTraits = FontTraits(0)) const;

+ FontCacheKey cacheKey(const FontFaceCreationParams&, FontTraits desiredTraits = FontTraits(0)) const;

void setFamily(const FontFamily& family) { m_familyList = family; }

void setComputedSize(float s) { m_computedSize = clampToFloat(s); }

« no previous file with comments | « Source/platform/fonts/FontCacheKey.h ('k') | Source/platform/fonts/FontDescription.cpp » ('j') | no next file with comments »