Fix font family based fallback font selection

Source/platform/fonts/skia/FontCacheSkia.cpp

 /*
  * Copyright (c) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
+#if !OS(WIN) && !OS(ANDROID)
+#include "SkFontConfigInterface.h"
+#endif
 #include "SkFontMgr.h"
+#include "SkStream.h"
 #include "SkTypeface.h"
 #include "platform/NotImplemented.h"
 #include "platform/fonts/AlternateFontFamily.h"
 #include "platform/fonts/FontCache.h"
 #include "platform/fonts/FontDescription.h"
+#include "platform/fonts/FontFaceCreationParams.h"
 #include "platform/fonts/SimpleFontData.h"
 #include "wtf/Assertions.h"
 #include "wtf/text/AtomicString.h"
 #include "wtf/text/CString.h"
 #include <unicode/locid.h>
 
+#if !OS(WIN) && !OS(ANDROID)
+static SkStream* streamForFontconfigInterfaceId(int fontconfigInterfaceId)
+{
+    SkAutoTUnref<SkFontConfigInterface> fci(SkFontConfigInterface::RefGlobal());
+    SkFontConfigInterface::FontIdentity fontIdentity;
+    fontIdentity.fID = fontconfigInterfaceId;
+    return fci->openStream(fontIdentity);
+}
+#endif
+
 namespace WebCore {
 
 void FontCache::platformInit()
 {
 }
 
 #if !OS(WIN) && !OS(ANDROID)
 PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(const FontDescription& fontDescription, UChar32 c, const SimpleFontData*)
 {
     icu::Locale locale = icu::Locale::getDefault();
     FontCache::PlatformFallbackFont fallbackFont;
     FontCache::getFontForCharacter(c, locale.getLanguage(), &fallbackFont);
     if (fallbackFont.name.isEmpty())
         return nullptr;
 
-    AtomicString atomicFamily(fallbackFont.name);
+    FontFaceCreationParams creationParams;
+    creationParams = FontFaceCreationParams(fallbackFont.fontconfigInterfaceId, fallbackFont.ttcIndex);
+
     // Changes weight and/or italic of given FontDescription depends on
     // the result of fontconfig so that keeping the correct font mapping
     // of the given character. See http://crbug.com/32109 for details.
     bool shouldSetSyntheticBold = false;
     bool shouldSetSyntheticItalic = false;
     FontDescription description(fontDescription);
     if (fallbackFont.isBold && description.weight() < FontWeightBold)
         description.setWeight(FontWeightBold);
     if (!fallbackFont.isBold && description.weight() >= FontWeightBold) {
         shouldSetSyntheticBold = true;
         description.setWeight(FontWeightNormal);
     }
     if (fallbackFont.isItalic && description.style() == FontStyleNormal)
         description.setStyle(FontStyleItalic);
     if (!fallbackFont.isItalic && description.style() == FontStyleItalic) {
         shouldSetSyntheticItalic = true;
         description.setStyle(FontStyleNormal);
     }
 
-    FontPlatformData* substitutePlatformData = getFontPlatformData(description, atomicFamily);
+    FontPlatformData* substitutePlatformData = getFontPlatformData(description, creationParams);
     if (!substitutePlatformData)
         return nullptr;
     FontPlatformData platformData = FontPlatformData(*substitutePlatformData);
     platformData.setSyntheticBold(shouldSetSyntheticBold);
     platformData.setSyntheticItalic(shouldSetSyntheticItalic);
     return fontDataFromFontPlatformData(&platformData, DoNotRetain);
 }
 
 #endif // !OS(WIN) && !OS(ANDROID)
 
 PassRefPtr<SimpleFontData> FontCache::getLastResortFallbackFont(const FontDescription& description, ShouldRetain shouldRetain)
 {
-    const AtomicString fallbackFontFamily = getFallbackFontFamily(description);
-    const FontPlatformData* fontPlatformData = getFontPlatformData(description, fallbackFontFamily);
+    const FontFaceCreationParams fallbackCreationParams(getFallbackFontFamily(description));
+    const FontPlatformData* fontPlatformData = getFontPlatformData(description, fallbackCreationParams);
 
     // We should at least have Sans or Arial which is the last resort fallback of SkFontHost ports.
     if (!fontPlatformData) {
-        DEFINE_STATIC_LOCAL(const AtomicString, sansStr, ("Sans", AtomicString::ConstructFromLiteral));
-        fontPlatformData = getFontPlatformData(description, sansStr);
+        DEFINE_STATIC_LOCAL(const FontFaceCreationParams, sansCreationParams, (AtomicString("Sans", AtomicString::ConstructFromLiteral)));
+        fontPlatformData = getFontPlatformData(description, sansCreationParams);
     }
     if (!fontPlatformData) {
-        DEFINE_STATIC_LOCAL(const AtomicString, arialStr, ("Arial", AtomicString::ConstructFromLiteral));
-        fontPlatformData = getFontPlatformData(description, arialStr);
+        DEFINE_STATIC_LOCAL(const FontFaceCreationParams, arialCreationParams, (AtomicString("Arial", AtomicString::ConstructFromLiteral)));
+        fontPlatformData = getFontPlatformData(description, arialCreationParams);
     }
 
     // TODO(scottmg|eae): Trying to identify crashes in http://crbug.com/383542
     if (!fontPlatformData)
         CRASH();
     return fontDataFromFontPlatformData(fontPlatformData, shouldRetain);
 }
 
-PassRefPtr<SkTypeface> FontCache::createTypeface(const FontDescription& fontDescription, const AtomicString& family, CString& name)
+PassRefPtr<SkTypeface> FontCache::createTypeface(const FontDescription& fontDescription, const FontFaceCreationParams& creationParams, CString& name)
 {
+#if !OS(WIN) && !OS(ANDROID)
+    if (creationParams.creationType() == CreateFontByFciIdAndTtcIndex) {
+        // TODO(dro): crbug.com/381620 Use creationParams.ttcIndex() after
+        // https://code.google.com/p/skia/issues/detail?id=1186 gets fixed.
+        SkTypeface* typeface = SkTypeface::CreateFromStream(streamForFontconfigInterfaceId(creationParams.fontconfigInterfaceId()));
+        return adoptRef(typeface);
+    }
+#endif
+
+    AtomicString family = creationParams.family();
     // If we're creating a fallback font (e.g. "-webkit-monospace"), convert the name into
     // the fallback name (like "monospace") that fontconfig understands.
     if (!family.length() || family.startsWith("-webkit-")) {
         name = getFallbackFontFamily(fontDescription).string().utf8();
     } else {
         // convert the name to utf8
         name = family.utf8();
     }
 
     int style = SkTypeface::kNormal;
@@ skipping 11 matching lines @@
     }
     // FIXME: Use SkFontStyle and matchFamilyStyle instead of legacyCreateTypeface.
     if (m_fontManager)
         return adoptRef(m_fontManager->legacyCreateTypeface(name.data(), style));
 #endif
 
     return adoptRef(SkTypeface::CreateFromName(name.data(), static_cast<SkTypeface::Style>(style)));
 }
 
 #if !OS(WIN)
-FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontDescription, const AtomicString& family, float fontSize)
+FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontDescription, const FontFaceCreationParams& creationParams, float fontSize)
 {
     CString name;
-    RefPtr<SkTypeface> tf(createTypeface(fontDescription, family, name));
+    RefPtr<SkTypeface> tf(createTypeface(fontDescription, creationParams, name));
     if (!tf)
         return 0;
 
     FontPlatformData* result = new FontPlatformData(tf,
         name.data(),
         fontSize,
         (fontDescription.weight() >= FontWeightBold && !tf->isBold()) || fontDescription.isSyntheticBold(),
         (fontDescription.style() && !tf->isItalic()) || fontDescription.isSyntheticItalic(),
         fontDescription.orientation(),
         fontDescription.useSubpixelPositioning());
     return result;
 }
 #endif // !OS(WIN)
 
 } // namespace WebCore