Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 307223006: Call _UpdateBranchHeads within _Clone. (Closed)

Created:
6 years, 6 months ago by Michael Moss
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Sergiy Byelozyorov
Visibility:
Public.

Description

Call _UpdateBranchHeads within _Clone. This will avoid errors where _Clone is called for a new DEP, but where the DEP refers to a branch commit, thus causing the clone to fail because it can't checkout that commit (such as happens currently with 'fetch v8'). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient_scm.py View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Moss
6 years, 6 months ago (2014-06-02 21:34:52 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-02 21:45:22 UTC) #2
Michael Moss
The CQ bit was checked by mmoss@chromium.org
6 years, 6 months ago (2014-06-02 21:50:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/307223006/1
6 years, 6 months ago (2014-06-02 21:51:36 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:53:30 UTC) #5
Message was sent while issue was closed.
Change committed as 274347

Powered by Google App Engine
This is Rietveld 408576698