Issue 307223004: Merge 273839 "Update UMA to track bypasses due to 4xx responses ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307223004: Merge 273839 "Update UMA to track bypasses due to 4xx responses ..." (Closed)

Created:
6 years, 6 months ago by bengr

Modified:
6 years, 6 months ago

Reviewers:
bengr

CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

Merge 273839 "Update UMA to track bypasses due to 4xx responses ..." > Update UMA to track bypasses due to 4xx responses that are missing the proxy's via header and bypasses due to network errors. > > BUG=376148 > > Review URL: https://codereview.chromium.org/298883011 TBR=bengr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274258

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -28 lines)			Patch
M	google_apis/gcm/engine/connection_factory_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/proxy_resolving_client_socket.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_response_headers.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/http/http_response_headers_unittest.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	net/http/http_stream_factory_impl_job.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/proxy/proxy_service.h	View	6 chunks	+19 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_service.cc	View	6 chunks	+30 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_service_unittest.cc	View	18 chunks	+38 lines, -19 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+21 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

bengr

6 years, 6 months ago (2014-06-02 16:30:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r274258 (tree was closed).