Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 307213002: Disabled StartupBrowserCreatorTest.UpdateWithTwoProfiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <string> 6 #include <string>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 691 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 pref1.urls = urls1; 702 pref1.urls = urls1;
703 SessionStartupPref::SetStartupPref(profile1, pref1); 703 SessionStartupPref::SetStartupPref(profile1, pref1);
704 SessionStartupPref pref2(SessionStartupPref::URLS); 704 SessionStartupPref pref2(SessionStartupPref::URLS);
705 pref2.urls = urls2; 705 pref2.urls = urls2;
706 SessionStartupPref::SetStartupPref(profile2, pref2); 706 SessionStartupPref::SetStartupPref(profile2, pref2);
707 707
708 profile1->GetPrefs()->CommitPendingWrite(); 708 profile1->GetPrefs()->CommitPendingWrite();
709 profile2->GetPrefs()->CommitPendingWrite(); 709 profile2->GetPrefs()->CommitPendingWrite();
710 } 710 }
711 711
712 #if defined (OS_MACOSX) 712 // See crbug.com/376184 about improvements to this test on Mac.
713 // crbug.com/376184 713 // Disabled because it's flaky. http://crbug.com/379579
714 #define MAYBE_UpdateWithTwoProfiles DISABLED_UpdateWithTwoProfiles 714 IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest,
715 #else 715 DISABLED_UpdateWithTwoProfiles) {
716 #define MAYBE_UpdateWithTwoProfiles UpdateWithTwoProfiles
717 #endif
718
719 IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, MAYBE_UpdateWithTwoProfiles) {
720 #if defined(OS_WIN) && defined(USE_ASH) 716 #if defined(OS_WIN) && defined(USE_ASH)
721 // Disable this test in Metro+Ash for now (http://crbug.com/262796). 717 // Disable this test in Metro+Ash for now (http://crbug.com/262796).
722 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests)) 718 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
723 return; 719 return;
724 #endif 720 #endif
725 721
726 // Make StartupBrowserCreator::WasRestarted() return true. 722 // Make StartupBrowserCreator::WasRestarted() return true.
727 StartupBrowserCreator::was_restarted_read_ = false; 723 StartupBrowserCreator::was_restarted_read_ = false;
728 PrefService* pref_service = g_browser_process->local_state(); 724 PrefService* pref_service = g_browser_process->local_state();
729 pref_service->SetBoolean(prefs::kWasRestarted, true); 725 pref_service->SetBoolean(prefs::kWasRestarted, true);
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 ASSERT_EQ(1, tab_strip->count()); 1377 ASSERT_EQ(1, tab_strip->count());
1382 EXPECT_EQ("title1.html", 1378 EXPECT_EQ("title1.html",
1383 tab_strip->GetWebContentsAt(0)->GetURL().ExtractFileName()); 1379 tab_strip->GetWebContentsAt(0)->GetURL().ExtractFileName());
1384 } 1380 }
1385 #endif // defined(ENABLE_CONFIGURATION_POLICY) 1381 #endif // defined(ENABLE_CONFIGURATION_POLICY)
1386 1382
1387 #endif // !defined(OS_LINUX) || !defined(GOOGLE_CHROME_BUILD) || 1383 #endif // !defined(OS_LINUX) || !defined(GOOGLE_CHROME_BUILD) ||
1388 // defined(ENABLE_CONFIGURATION_POLICY) 1384 // defined(ENABLE_CONFIGURATION_POLICY)
1389 1385
1390 #endif // !defined(OS_CHROMEOS) 1386 #endif // !defined(OS_CHROMEOS)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698