Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 307193002: Un-inline KURL's default constructor to avoid bloating (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Un-inline KURL's default constructor to avoid bloating Un-inline KURL's default constructor to avoid bloating. KURL has non-POD data members and its constructor is thus non-trivial. This reduces the release binary size by ~17Kb. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M Source/platform/weborigin/KURL.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/platform/weborigin/KURL.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 6 months ago (2014-06-01 03:35:50 UTC) #1
eseidel
lgtm
6 years, 6 months ago (2014-06-01 04:01:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/307193002/1
6 years, 6 months ago (2014-06-01 04:01:23 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-01 05:24:50 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 06:42:12 UTC) #5
Message was sent while issue was closed.
Change committed as 175216

Powered by Google App Engine
This is Rietveld 408576698