Issue 307193002: Un-inline KURL's default constructor to avoid bloating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307193002: Un-inline KURL's default constructor to avoid bloating (Closed)

Created:
6 years, 6 months ago by Inactive

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Un-inline KURL's default constructor to avoid bloating Un-inline KURL's default constructor to avoid bloating. KURL has non-POD data members and its constructor is thus non-trivial. This reduces the release binary size by ~17Kb. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175216

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	Source/platform/weborigin/KURL.h	View		1 chunk	+1 line, -6 lines	0 comments	Download
	M	Source/platform/weborigin/KURL.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/307193002/1

6 years, 6 months ago (2014-06-01 04:01:23 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-01 05:24:50 UTC) #4

Message was sent while issue was closed.

Change committed as 175216