components/nacl/renderer/nexe_load_manager.cc - Issue 307173002: Remove PlatformFile from components/nacl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/nexe_load_manager.cc

Issue 307173002: Remove PlatformFile from components/nacl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update NexeFdCallback definition Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/renderer/nexe_load_manager.cc

diff --git a/components/nacl/renderer/nexe_load_manager.cc b/components/nacl/renderer/nexe_load_manager.cc

index d2efba4cccbf955723a968a04971bbdf23da791b..0c937392230c0cb5dd4f92ed0850e61f4e67c6e0 100644

--- a/components/nacl/renderer/nexe_load_manager.cc

+++ b/components/nacl/renderer/nexe_load_manager.cc

@@ -107,7 +107,7 @@ NexeLoadManager::~NexeLoadManager() {

}

void NexeLoadManager::NexeFileDidOpen(int32_t pp_error,

- base::PlatformFile file,

+ const base::File& file,

int32_t http_status,

int64_t nexe_bytes_read,

const std::string& url,

@@ -120,7 +120,7 @@ void NexeLoadManager::NexeFileDidOpen(int32_t pp_error,

"NaCl.HttpStatusCodeClass.Nexe.NotInstalledApp",

http_status);

- if (pp_error != PP_OK || file == base::kInvalidPlatformFileValue) {

+ if (pp_error != PP_OK || !file.IsValid()) {

if (pp_error == PP_ERROR_ABORTED) {

ReportLoadAbort();

} else if (pp_error == PP_ERROR_NOACCESS) {