Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 307093002: Covert self time to milliseconds before passing it into pie chart generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 * @param {boolean} loadedFromFile 732 * @param {boolean} loadedFromFile
733 * @param {?WebInspector.TimelineTraceEventBindings} bindings 733 * @param {?WebInspector.TimelineTraceEventBindings} bindings
734 * @param {!WebInspector.Target} target 734 * @param {!WebInspector.Target} target
735 * @return {!DocumentFragment} 735 * @return {!DocumentFragment}
736 */ 736 */
737 WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve nt, model, linkifier, imagePreviewElement, relatedNode, loadedFromFile, bindings , target) 737 WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve nt, model, linkifier, imagePreviewElement, relatedNode, loadedFromFile, bindings , target)
738 { 738 {
739 var fragment = document.createDocumentFragment(); 739 var fragment = document.createDocumentFragment();
740 var stats = WebInspector.TimelineUIUtils._aggregatedStatsForTraceEvent(model , event); 740 var stats = WebInspector.TimelineUIUtils._aggregatedStatsForTraceEvent(model , event);
741 var pieChart = stats.hasChildren ? 741 var pieChart = stats.hasChildren ?
742 WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats, Web Inspector.TimelineUIUtils.styleForTimelineEvent(event.name).category, event.self Time) : 742 WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats, Web Inspector.TimelineUIUtils.styleForTimelineEvent(event.name).category, event.self Time / 1000) :
743 WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats); 743 WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats);
744 fragment.appendChild(pieChart); 744 fragment.appendChild(pieChart);
745 745
746 var recordTypes = WebInspector.TimelineModel.RecordType; 746 var recordTypes = WebInspector.TimelineModel.RecordType;
747 747
748 // The messages may vary per event.name; 748 // The messages may vary per event.name;
749 var callSiteStackTraceLabel; 749 var callSiteStackTraceLabel;
750 var callStackLabel; 750 var callStackLabel;
751 var relatedNodeLabel; 751 var relatedNodeLabel;
752 752
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
1385 for (var i = 0; i < stackTrace.length; ++i) { 1385 for (var i = 0; i < stackTrace.length; ++i) {
1386 var stackFrame = stackTrace[i]; 1386 var stackFrame = stackTrace[i];
1387 var row = stackTraceElement.createChild("div"); 1387 var row = stackTraceElement.createChild("div");
1388 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)")); 1388 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)"));
1389 row.createTextChild(" @ "); 1389 row.createTextChild(" @ ");
1390 var urlElement = this._linkifier.linkifyLocation(this._target, stack Frame.url, stackFrame.lineNumber - 1); 1390 var urlElement = this._linkifier.linkifyLocation(this._target, stack Frame.url, stackFrame.lineNumber - 1);
1391 row.appendChild(urlElement); 1391 row.appendChild(urlElement);
1392 } 1392 }
1393 } 1393 }
1394 } 1394 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698