Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: trunk/src/content/browser/renderer_host/render_process_host_impl.cc

Issue 307063003: Revert 273745 "Implements RTP header dumping." due to memory leak (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/render_process_host_impl.cc
===================================================================
--- trunk/src/content/browser/renderer_host/render_process_host_impl.cc (revision 273765)
+++ trunk/src/content/browser/renderer_host/render_process_host_impl.cc (working copy)
@@ -807,10 +807,9 @@
}
#if defined(ENABLE_WEBRTC)
- p2p_socket_dispatcher_host_ = new P2PSocketDispatcherHost(
+ AddFilter(new P2PSocketDispatcherHost(
resource_context,
- browser_context->GetRequestContextForRenderProcess(GetID()));
- AddFilter(p2p_socket_dispatcher_host_);
+ browser_context->GetRequestContextForRenderProcess(GetID())));
#endif
AddFilter(new TraceMessageFilter());
@@ -1509,30 +1508,6 @@
base::Callback<void(const std::string&)> callback) {
webrtc_log_message_callback_ = callback;
}
-
-RenderProcessHostImpl::WebRtcStopRtpDumpCallback
-RenderProcessHostImpl::StartRtpDump(
- bool incoming,
- bool outgoing,
- const WebRtcRtpPacketCallback& packet_callback) {
- if (!p2p_socket_dispatcher_host_)
- return WebRtcStopRtpDumpCallback();
-
- BrowserThread::PostTask(BrowserThread::IO,
- FROM_HERE,
- base::Bind(&P2PSocketDispatcherHost::StartRtpDump,
- p2p_socket_dispatcher_host_,
- incoming,
- outgoing,
- packet_callback));
-
- if (stop_rtp_dump_callback_.is_null()) {
- stop_rtp_dump_callback_ =
- base::Bind(&P2PSocketDispatcherHost::StopRtpDumpOnUIThread,
- p2p_socket_dispatcher_host_);
- }
- return stop_rtp_dump_callback_;
-}
#endif
IPC::ChannelProxy* RenderProcessHostImpl::GetChannel() {

Powered by Google App Engine
This is Rietveld 408576698