Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc

Issue 307063003: Revert 273745 "Implements RTP header dumping." due to memory leak (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc
===================================================================
--- trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc (revision 273765)
+++ trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc (working copy)
@@ -66,12 +66,12 @@
}
P2PSocketHostUdp::P2PSocketHostUdp(IPC::Sender* message_sender,
- int socket_id,
+ int id,
P2PMessageThrottler* throttler)
- : P2PSocketHost(message_sender, socket_id),
- socket_(
- new net::UDPServerSocket(GetContentClient()->browser()->GetNetLog(),
- net::NetLog::Source())),
+ : P2PSocketHost(message_sender, id),
+ socket_(new net::UDPServerSocket(
+ GetContentClient()->browser()->GetNetLog(),
+ net::NetLog::Source())),
send_pending_(false),
last_dscp_(net::DSCP_CS0),
throttler_(throttler) {
@@ -173,9 +173,6 @@
message_sender_->Send(new P2PMsg_OnDataReceived(
id_, recv_address_, data, base::TimeTicks::Now()));
-
- if (dump_incoming_rtp_packet_)
- DumpRtpPacket(&data[0], data.size(), true);
} else if (result < 0 && !IsTransientError(result)) {
LOG(ERROR) << "Error when reading from UDP socket: " << result;
OnError();
@@ -264,9 +261,6 @@
} else {
HandleSendResult(packet.id, result);
}
-
- if (dump_outgoing_rtp_packet_)
- DumpRtpPacket(packet.data->data(), packet.size, false);
}
void P2PSocketHostUdp::OnSend(uint64 packet_id, int result) {

Powered by Google App Engine
This is Rietveld 408576698