Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 307053002: Revert of Change directory if the active list item on navigation list is changed. (Closed)

Created:
6 years, 6 months ago by fukino
Modified:
6 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Revert of Change directory if the active list item on navigation list is changed. (https://codereview.chromium.org/303503004/) Reason for revert: Added browser test broke Linux ChromiumOS Tests (dbg). This may be flakiness and I should investigate the reason before relanding Original issue's description: > Change directory if the active list item on navigation list is changed. > > We want to change current directory if the active item on navigation list is changed. > But we don't want to change current directory when listed items are spliced or permuted. > In both cases, 'change' event is dispatched from selection model and we can't distinguish these cases from event itself. > currentActiveItem_ is introduced to detect change of actual active item. > > BUG=375663 > TEST=go through steps in Issue 375663 and 361047 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273601 TBR=yoshiki@chromium.org NOTREECHECKS=true NOTRY=true BUG=375663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -473 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/background.js View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_manager_browsertest/folder_shortcuts.js View 1 chunk +0 lines, -409 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/background/js/test_util.js View 1 chunk +0 lines, -18 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/navigation_list.js View 4 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fukino
Created Revert of Change directory if the active list item on navigation list is changed.
6 years, 6 months ago (2014-05-30 05:18:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/307053002/1
6 years, 6 months ago (2014-05-30 05:19:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 05:19:31 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 05:19:31 UTC) #4
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698