Issue 307033002: Non-SFI NaCl: CLOCK_SYSTEM_TRACE fails gracefully on Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307033002: Non-SFI NaCl: CLOCK_SYSTEM_TRACE fails gracefully on Chrome OS

Created:
6 years, 6 months ago by hamaji

Modified:
6 years, 6 months ago

Reviewers:

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Non-SFI NaCl: CLOCK_SYSTEM_TRACE fails gracefully on Chrome OS chrome://tracing uses TimeTicks::NowFromSystemTraceTime in base/time/time_posix.cc. This function will fall back to CLOCK_MONOTONIC if clock_gettime(CLCOK_SYSTEM_TRACE) returns EPERM. TEST=nacl_loader_unittests # on i686 and ARM Chrome OS TEST=trybot BUG=378063

Patch Set 1 #

Patch Set 2 : Use only OS_LINUX to decide whether we define kClockSystemTrace #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -22 lines)			Patch
M	base/time/time.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	base/time/time_posix.cc	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download
M	components/nacl/loader/nonsfi/nonsfi_sandbox.cc	View		2 chunks	+21 lines, -13 lines	0 comments	Download
M	components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc	View		2 chunks	+20 lines, -0 lines	0 comments	Download