Chromium Code Reviews

Issue 307013003: Revert 273810 "Added alternative configuration for the data redu..." (Closed)

Created:
6 years, 6 months ago by battre
Modified:
6 years, 6 months ago
Reviewers:
bengr
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273810 "Added alternative configuration for the data redu..." Reverting due to failing tests. See http://crbug.com/370039#c5 for details. > Added alternative configuration for the data reduction proxy > > Added a second configuration that can support two http proxies and one https proxy. In the process, added a new DataReductionProxyParams object to encapsulate static configuration details and made DataReductionSettingsAndroid a BrowserKeyedContextService. > > BUG=370039 > > Review URL: https://codereview.chromium.org/286013002 TBR=bengr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273824

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+518 lines, -1504 lines)
M trunk/src/android_webview/browser/aw_browser_context.cc View 3 chunks +16 lines, -21 lines 0 comments
M trunk/src/android_webview/browser/net/aw_url_request_context_getter.cc View 2 chunks +9 lines, -15 lines 0 comments
M trunk/src/android_webview/native/aw_contents_statics.cc View 1 chunk +2 lines, -2 lines 0 comments
M trunk/src/build/common.gypi View 3 chunks +0 lines, -18 lines 0 comments
M trunk/src/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java View 4 chunks +10 lines, -10 lines 0 comments
M trunk/src/chrome/browser/io_thread.h View 3 chunks +1 line, -3 lines 0 comments
M trunk/src/chrome/browser/io_thread.cc View 4 chunks +9 lines, -22 lines 0 comments
M trunk/src/chrome/browser/net/predictor.cc View 1 chunk +2 lines, -2 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h View 1 chunk +1 line, -2 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.cc View 2 chunks +5 lines, -13 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc View 5 chunks +9 lines, -25 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h View 2 chunks +8 lines, -17 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc View 6 chunks +35 lines, -39 lines 0 comments
D trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_factory_android.h View 1 chunk +0 lines, -47 lines 0 comments
D trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_factory_android.cc View 1 chunk +0 lines, -63 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc View 4 chunks +7 lines, -22 lines 0 comments
M trunk/src/chrome/browser/net/spdyproxy/proxy_advisor.cc View 3 chunks +1 line, -8 lines 0 comments
M trunk/src/chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +2 lines, -3 lines 0 comments
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments
M trunk/src/components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments
M trunk/src/components/data_reduction_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h View 1 chunk +0 lines, -2 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc View 2 chunks +1 line, -2 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc View 6 chunks +4 lines, -21 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h View 1 chunk +1 line, -2 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc View 2 chunks +3 lines, -9 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_config_service_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_configurator.h View 1 chunk +1 line, -3 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc View 2 chunks +2 lines, -11 lines 0 comments
D trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_params.h View 1 chunk +0 lines, -177 lines 0 comments
D trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc View 1 chunk +0 lines, -281 lines 0 comments
D trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc View 1 chunk +0 lines, -295 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_prefs.cc View 1 chunk +0 lines, -4 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings.h View 9 chunks +79 lines, -42 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc View 22 chunks +219 lines, -123 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h View 4 chunks +10 lines, -40 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc View 8 chunks +17 lines, -49 lines 0 comments
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc View 12 chunks +62 lines, -81 lines 0 comments
M trunk/src/components/data_reduction_proxy/common/data_reduction_proxy_pref_names.h View 1 chunk +0 lines, -1 line 0 comments
M trunk/src/components/data_reduction_proxy/common/data_reduction_proxy_pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments
M trunk/src/components/data_reduction_proxy/common/data_reduction_proxy_switches.h View 1 chunk +0 lines, -4 lines 0 comments
M trunk/src/components/data_reduction_proxy/common/data_reduction_proxy_switches.cc View 2 chunks +0 lines, -13 lines 0 comments

Messages

Total messages: 2 (0 generated)
battre
6 years, 6 months ago (2014-05-30 13:43:43 UTC) #1
battre
6 years, 6 months ago (2014-05-30 13:44:45 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r273824 (tree was closed).

Powered by Google App Engine