Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: mojo/services/view_manager/view_manager_connection.cc

Issue 307003004: Fixes bug where IViewManagerClient could be messaged unnecessarily (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_connection.cc
diff --git a/mojo/services/view_manager/view_manager_connection.cc b/mojo/services/view_manager/view_manager_connection.cc
index d42c403d32253c86b27a36be8e9888642487ecfe..6b7a8c8f6eb34614fdab7e46be9c88f9d6a35120 100644
--- a/mojo/services/view_manager/view_manager_connection.cc
+++ b/mojo/services/view_manager/view_manager_connection.cc
@@ -127,6 +127,7 @@ void ViewManagerConnection::ProcessNodeHierarchyChanged(
RemoveFromKnown(node);
client()->OnNodeDeleted(NodeIdToTransportId(node->id()),
server_change_id);
+ root_node_manager_->OnConnectionMessagedClient(id_);
return;
}
}
@@ -185,9 +186,12 @@ void ViewManagerConnection::ProcessNodeDeleted(
if (in_known) {
client()->OnNodeDeleted(NodeIdToTransportId(node), server_change_id);
- } else if (root_node_manager_->IsProcessingChange()) {
+ root_node_manager_->OnConnectionMessagedClient(id_);
+ } else if (root_node_manager_->IsProcessingChange() &&
+ !root_node_manager_->DidConnectionMessageClient(id_)) {
client()->OnServerChangeIdAdvanced(
root_node_manager_->next_server_change_id() + 1);
+ root_node_manager_->OnConnectionMessagedClient(id_);
}
}
« no previous file with comments | « mojo/services/view_manager/root_node_manager.cc ('k') | mojo/services/view_manager/view_manager_connection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698