Issue 307003004: Fixes bug where IViewManagerClient could be messaged unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307003004: Fixes bug where IViewManagerClient could be messaged unnecessarily (Closed)

Created:
6 years, 6 months ago by sky

Modified:
6 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes bug where IViewManagerClient could be messaged unnecessarily When deleting a node view manager could end up messaging client both of the delete and to advance. If delete is sent there is no need to send an advance too. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274013

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -42 lines)			Patch
M	mojo/services/view_manager/root_node_manager.h	View	1	5 chunks	+38 lines, -13 lines	0 comments	Download
M	mojo/services/view_manager/root_node_manager.cc	View		4 chunks	+24 lines, -16 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	mojo/services/view_manager/view_manager_connection_unittest.cc	View		3 chunks	+6 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/307003004/20001

6 years, 6 months ago (2014-05-30 20:36:25 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-05-31 02:05:20 UTC) #5

Message was sent while issue was closed.

Change committed as 274013

Expand Messages | Collapse Messages