Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 307003002: Omnibox: HistoryQuick Provider Scoring: Boost Bookmarks (Closed)

Created:
6 years, 6 months ago by Mark P
Modified:
6 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Omnibox: HistoryQuick Provider Scoring: Boost Bookmarks Give untyped bookmarked URLs a boost. (Change the default value of an untyped visit to a bookmark from 1 to 10. A typed visit still scores 20.) This has evaluated positively. BUG=330214, 247715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/omnibox/omnibox_field_trial.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark P
ptal, should be trivial. --mark
6 years, 6 months ago (2014-05-30 00:10:38 UTC) #1
Peter Kasting
LGTM
6 years, 6 months ago (2014-05-30 00:12:19 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 6 months ago (2014-05-30 00:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/307003002/1
6 years, 6 months ago (2014-05-30 00:21:21 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 10:06:59 UTC) #5
Message was sent while issue was closed.
Change committed as 273778

Powered by Google App Engine
This is Rietveld 408576698