Settings: do the same-path check after the main page special-case.

chrome/browser/ui/webui/options/options_browsertest.js

Index: chrome/browser/ui/webui/options/options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/options_browsertest.js b/chrome/browser/ui/webui/options/options_browsertest.js
index 591771f0972cec2b4d78f944ee7846d293605575..1f890691f1290b0e58f922080c1e9e590fbc8f92 100644
--- a/chrome/browser/ui/webui/options/options_browsertest.js
+++ b/chrome/browser/ui/webui/options/options_browsertest.js
@@ -636,6 +636,22 @@ TEST_F('OptionsWebUIExtendedTest', 'CloseOverlay', function() {
   });
 });
 
+// Test that closing an overlay that did not push history when opening does not
+// again push history.
+TEST_F('OptionsWebUIExtendedTest', 'CloseOverlayNoHistory', function() {
+  // Open the profile delete prompt.
+  ManageProfileOverlay.showDeleteDialog(BrowserOptions.getCurrentProfile());
+
+  // Opening the prompt does not add to the history.
+  var self = this;
+  this.verifyHistory_([''], function() {
+    // Close the overlay.
+    OptionsPage.closeOverlay();
+    // Still no history changes.
+    self.verifyHistory_([''], testDone);
+  });

[Dan Beam, 2014/05/30 21:13:17]

nit: instead of making |self|

  this.verifyHistory_([''], function() {
    ...
    this.verifyHistory_(...);
  }.bind(this));

[davidben, 2014/05/30 21:20:36]

Done. (Cool, I'm glad that's how we should be doing it in future. I much prefer
that idiom but everything else in this file uses self.)

+});
+
 // Make sure an overlay isn't closed (even temporarily) when another overlay is
 // opened on top.
 TEST_F('OptionsWebUIExtendedTest', 'OverlayAboveNoReset', function() {