Settings: do the same-path check after the main page special-case.

Settings: do the same-path check after the main page special-case.

This fixes a bug where overlays that don't push history entries still did when
closing them. Add a browser test to test this case.

BUG=379055
TEST=see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274340

[davidben, 2014-05-30 17:44:59]

Yet another follow-up fix.

[Dan Beam, 2014-05-30 21:13:17]

webui development is fun, right?!  lgtm

https://codereview.chromium.org/306993006/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/306993006/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/options_browsertest.js:652: });
nit: instead of making |self|

  this.verifyHistory_([''], function() {
    ...
    this.verifyHistory_(...);
  }.bind(this));

[davidben, 2014-05-30 21:20:36]

https://codereview.chromium.org/306993006/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/306993006/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/options_browsertest.js:652: });
On 2014/05/30 21:13:17, Dan Beam wrote:
> nit: instead of making |self|
> 
>   this.verifyHistory_([''], function() {
>     ...
>     this.verifyHistory_(...);
>   }.bind(this));

Done. (Cool, I'm glad that's how we should be doing it in future. I much prefer
that idiom but everything else in this file uses self.)

[davidben, 2014-05-30 21:20:47]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-30 21:27:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/306993006/20001

[commit-bot: I haz the power, 2014-05-31 02:40:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-31 03:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 03:57:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[davidben, 2014-06-02 17:25:06]

On 2014/05/31 03:57:20, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

Tweaked slightly to test the doNotTrackConfirm page instead; the profile
deletion prompt code doesn't work on CrOS.

[davidben, 2014-06-02 17:25:33]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-06-02 17:26:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/306993006/40001

[commit-bot: I haz the power, 2014-06-02 21:37:35]

Change committed as 274340