Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: pkg/smoke/lib/codegen/recorder.dart

Issue 306993002: smoke: support named argument in annotations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/smoke/test/codegen/end_to_end_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/smoke/lib/codegen/recorder.dart
diff --git a/pkg/smoke/lib/codegen/recorder.dart b/pkg/smoke/lib/codegen/recorder.dart
index 073e8fef08580a0f5c0969aa8363d07855ef2d40..645d3acdee425137200faf6dd2b412478d8558a0 100644
--- a/pkg/smoke/lib/codegen/recorder.dart
+++ b/pkg/smoke/lib/codegen/recorder.dart
@@ -259,17 +259,17 @@ class Recorder {
}
var positionalArgs = [];
+ var namedArgs = {};
for (var arg in annotation.arguments.arguments) {
if (arg is NamedExpression) {
- throw new UnimplementedError(
- 'named arguments in constructors are not implemented in '
- 'smoke.codegen.recorder');
+ namedArgs[arg.name.label.name] = _convertExpression(arg.expression);
+ } else {
+ positionalArgs.add(_convertExpression(arg));
}
- positionalArgs.add(_convertExpression(arg));
}
return new ConstructorExpression(importUrlFor(element.library),
- element.enclosingElement.name, positionalArgs, const {});
+ element.enclosingElement.name, positionalArgs, namedArgs);
}
if (element is PropertyAccessorElement) {
« no previous file with comments | « no previous file | pkg/smoke/test/codegen/end_to_end_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698