Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 306963002: Omnibox: HistoryQuick Provider: Index Farther Into URL and Title (Closed)

Created:
6 years, 6 months ago by Mark P
Modified:
6 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Omnibox: HistoryQuick Provider: Index Farther Into URL and Title Record word break information for the first 200 characters in a URL or title, not the first 50 characters. This is important because we generally drop URL suggestions that we think do not match at a word break. Tested locally on a longer URL from the bug. TBR=sky (because this change is trivial) BUG=291294 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273837

Patch Set 1 #

Patch Set 2 : bump cache version #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/history/in_memory_url_index_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index_types_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/url_index_private_data.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
Mark P
PTAL. thanks, mark
6 years, 6 months ago (2014-05-29 18:31:19 UTC) #1
Peter Kasting
LGTM
6 years, 6 months ago (2014-05-29 18:33:48 UTC) #2
Peter Kasting
Do we need to flush any client databases or anything?
6 years, 6 months ago (2014-05-29 18:34:13 UTC) #3
Mark P
On 2014/05/29 18:34:13, Peter Kasting wrote: > Do we need to flush any client databases ...
6 years, 6 months ago (2014-05-29 18:43:25 UTC) #4
Peter Kasting
On 2014/05/29 18:43:25, Mark P wrote: > Please take another look. You also forgot to ...
6 years, 6 months ago (2014-05-29 18:44:13 UTC) #5
Mark P
On 2014/05/29 18:43:25, Mark P wrote: > On 2014/05/29 18:34:13, Peter Kasting wrote: > > ...
6 years, 6 months ago (2014-05-29 18:46:08 UTC) #6
Peter Kasting
LGTM again
6 years, 6 months ago (2014-05-29 18:46:50 UTC) #7
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 6 months ago (2014-05-29 18:47:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/306963002/20001
6 years, 6 months ago (2014-05-29 18:48:14 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 22:12:13 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 22:15:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/36349)
6 years, 6 months ago (2014-05-29 22:15:29 UTC) #12
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 6 months ago (2014-05-29 23:36:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/306963002/40001
6 years, 6 months ago (2014-05-29 23:39:58 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 04:32:21 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 04:58:56 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/189981)
6 years, 6 months ago (2014-05-30 04:58:56 UTC) #17
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 6 months ago (2014-05-30 13:50:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/306963002/40001
6 years, 6 months ago (2014-05-30 13:51:32 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 15:07:56 UTC) #20
Message was sent while issue was closed.
Change committed as 273837

Powered by Google App Engine
This is Rietveld 408576698