Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 306953006: Remove webkit- prefix from classes used by View Source (Closed)

Created:
6 years, 6 months ago by Sunil Ratnu
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove webkit- prefix from classes used by View Source Removing the webkit- prefix from viewsource as we do not want to keep it in blink. BUG=378867 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178725

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M LayoutTests/fast/frames/viewsource/viewsource-1-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-2-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-3-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-4-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-5-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-6-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-incomplete-token-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-unfinished-script-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/viewsource/viewsource-unfinished-textarea-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/viewsource-onmouseover-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/viewsource-script-tag-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/view-source.css View 1 3 5 chunks +21 lines, -21 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.cpp View 1 2 3 8 chunks +18 lines, -18 lines 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sunil Ratnu
PTAL.
6 years, 5 months ago (2014-07-22 16:21:50 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-22 17:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/306953006/60001
6 years, 5 months ago (2014-07-22 17:00:54 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-22 18:26:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 19:15:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30920)
6 years, 5 months ago (2014-07-22 19:15:27 UTC) #6
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 5 months ago (2014-07-23 03:32:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/306953006/60001
6 years, 5 months ago (2014-07-23 03:34:14 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 03:35:33 UTC) #9
Message was sent while issue was closed.
Change committed as 178725

Powered by Google App Engine
This is Rietveld 408576698