Issue 306953004: Fix the flakiness in the CreateNewFolder test

Issue 306953004: Fix the flakiness in the CreateNewFolder test (Closed)

Created:
6 years, 6 months ago by yoshiki

Modified:
6 years, 6 months ago

Reviewers:
hirono

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the flakiness in the CreateNewFolder test BUG=377636 TEST=run the test 50 times and no flakiness observed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273950

Patch Set 2 : Remove the debug log #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

hirono

lgtm with a nit. Thank you for fixing it! https://codereview.chromium.org/306953004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js File chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js (right): https://codereview.chromium.org/306953004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js#newcode67 chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js:67: ...

6 years, 6 months ago (2014-05-30 09:34:00 UTC) #2

yoshiki

Thanks! https://codereview.chromium.org/306953004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js File chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js (right): https://codereview.chromium.org/306953004/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js#newcode67 chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js:67: console.log('newFoloderListItemId: ' + newFoloderListItemId); On 2014/05/30 09:34:00, hirono ...

6 years, 6 months ago (2014-05-30 18:15:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/306953004/20001

6 years, 6 months ago (2014-05-30 18:18:10 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...

6 years, 6 months ago (2014-05-30 23:20:43 UTC) #6

Message was sent while issue was closed.

Change committed as 273950

Expand Messages | Collapse Messages