src/core/SkThreadPriv.h - Issue 306943003: SkLazyPtr, mk. 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkThreadPriv.h

Issue 306943003: SkLazyPtr, mk. 2 (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: drop static Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkThreadPriv.h

diff --git a/src/core/SkThreadPriv.h b/src/core/SkThreadPriv.h

index a9729216064ab25d35092310e96e73dd3791eef3..c44cca53509015e783e56c79b8cc086bd931f5cd 100644

--- a/src/core/SkThreadPriv.h

+++ b/src/core/SkThreadPriv.h

@@ -14,7 +14,7 @@

/** Atomic compare and set, for pointers.

* If *addr == before, set *addr to after. Always returns previous value of *addr.

- * This must act as a compiler barrier.

+ * This must issue a release barrier on success, acquire on failure, and always a compiler barrier.

static void* sk_atomic_cas(void** addr, void* before, void* after);

« no previous file with comments | « src/core/SkLazyPtr.h ('k') | src/core/SkXfermode.cpp » ('j') | no next file with comments »