Issue 30693007: Guard against misuse of IfBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 30693007: Guard against misuse of IfBuilder. (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer

Modified:
7 years, 2 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/hydrogen.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hey Sven, This one adds two ASSERTs to make sure that one does not use ...

7 years, 2 months ago (2013-10-22 11:18:47 UTC) #1

Benedikt Meurer

7 years, 2 months ago (2013-10-22 11:37:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17319 (presubmit successful).